Add exclude pattern for dotnet #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 18, 2024
| exclude, err := regexp.MatchString(excludePattern, projFilePath) | ||
| if err != nil { | ||
| log.Error(err) | ||
| continue |
There was a problem hiding this comment.
What kind of errors can be thrown here that we can accept and not killing the process?
if these "errors" are such we can accept it might be better to use log.Warn so it will not look like an Error to the customer that we didn't take care of or ignored
There was a problem hiding this comment.
I think an error is OK in this case, we log it just like we log when we can't parse at the above line.
There could be an error from the pattern or a lot of other reasons...
We got an error for this project so we report it and skip to the next, we don't want to fail all the build but still an error occur and it is not the full one, the customer may be at fault since we rely on input given to us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to exclude patterns for dotnet dependencies.